Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: explain installing browsers for e2e tests #6163

Merged
merged 1 commit into from
May 24, 2024
Merged

docs: explain installing browsers for e2e tests #6163

merged 1 commit into from
May 24, 2024

Conversation

thorn0
Copy link
Contributor

@thorn0 thorn0 commented May 22, 2024

just a tiny docs addition

@vercel Vercel
Copy link

vercel bot commented May 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2024 7:25pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2024 7:25pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 22, 2024
@github-actions GitHub Actions
Copy link

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 23.93 KB (0%) 479 ms (0%) 625 ms (+32.68% 🔺) 1.2 s
packages/lexical-rich-text/dist/LexicalRichText.js 34.59 KB (0%) 692 ms (0%) 1.3 s (+8.39% 🔺) 2 s
packages/lexical-plain-text/dist/LexicalPlainText.js 34.59 KB (0%) 692 ms (0%) 1.3 s (+25.4% 🔺) 2 s

StyleT
StyleT approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@StyleT StyleT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for this addition!

@StyleT StyleT added this pull request to the merge queue May 24, 2024
Merged via the queue into facebook:main with commit 5b8521c May 24, 2024
9 of 11 checks passed
This was referenced Jun 26, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StyleT StyleT StyleT approved these changes

@potatowagon potatowagon potatowagon approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

@ivailop7 ivailop7 Awaiting requested review from ivailop7 ivailop7 is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thorn0 @StyleT @potatowagon @facebook-github-bot