Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lexical] Bug Fix: delete line for selections ending with elements #6160

Merged
merged 1 commit into from
May 28, 2024

Conversation

DraXu3
Copy link
Contributor

@DraXu3 DraXu3 commented May 22, 2024

Description

This PR fixes line deletion operation via CMD (⌘) + Backspace combination on MacOS for cases when the current selection has an anchor of type element.

This is an extension of this PR which originally limited line deletion for text based selections only.

Closes: #6047

Test plan

  1. Open https://playground.lexical.dev/
  2. Type some text and then insert a sample image or any other element
  3. Press "CMD (⌘) + Backspace"
  4. Observe that the whole line is deleted

Before

1.mov

After

2.mov

@facebook-github-bot
Copy link
Contributor

Hi @DraXu3!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Copy link

vercel bot commented May 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2024 6:42pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2024 6:42pm

Copy link

github-actions bot commented May 22, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 23.93 KB (0%) 479 ms (0%) 459 ms (+16.68% 🔺) 937 ms
packages/lexical-rich-text/dist/LexicalRichText.js 34.59 KB (0%) 692 ms (0%) 1.3 s (+19.83% 🔺) 2 s
packages/lexical-plain-text/dist/LexicalPlainText.js 34.59 KB (0%) 692 ms (0%) 1.1 s (+11.26% 🔺) 1.8 s

@ivailop7 ivailop7 added the extended-tests Run extended e2e tests on a PR label May 22, 2024
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 22, 2024
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@StyleT StyleT added the contribution-week Issues that are good to be picked up for the contribution week label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. contribution-week Issues that are good to be picked up for the contribution week extended-tests Run extended e2e tests on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants