Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lexical] Move some codeblock tests from e2e to unit #6094

Merged
merged 8 commits into from
May 14, 2024
Merged

[Lexical] Move some codeblock tests from e2e to unit #6094

merged 8 commits into from
May 14, 2024

Conversation

Sahejkm
Copy link
Contributor

@Sahejkm Sahejkm commented May 13, 2024 •
edited
Loading

@vercel Vercel
Copy link

vercel bot commented May 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 2:13pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 2:13pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 13, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 13, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 23.93 KB (0%) 479 ms (0%) 189 ms (+11.57% 🔺) 668 ms
packages/lexical-rich-text/dist/LexicalRichText.js 34.56 KB (0%) 692 ms (0%) 558 ms (+42.14% 🔺) 1.3 s
packages/lexical-plain-text/dist/LexicalPlainText.js 34.51 KB (0%) 691 ms (0%) 619 ms (+15.32% 🔺) 1.4 s

zurfyx
zurfyx previously approved these changes May 13, 2024
View reviewed changes
@etrepum
Copy link
Collaborator

etrepum commented May 13, 2024

Looks like the merge generated output that prettier wants to reformat

etrepum
etrepum reviewed May 13, 2024
View reviewed changes
Copy link
Collaborator

@etrepum etrepum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have auth to approve, but this looks great! 👍

@Sahejkm Sahejkm added this pull request to the merge queue May 14, 2024
Merged via the queue into main with commit ec18fcf May 14, 2024
10 checks passed
This was referenced Jun 26, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etrepum etrepum etrepum left review comments

@2wheeh 2wheeh 2wheeh left review comments

@zurfyx zurfyx zurfyx approved these changes

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

@ivailop7 ivailop7 Awaiting requested review from ivailop7 ivailop7 is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Sahejkm @etrepum @zurfyx @2wheeh @facebook-github-bot