Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Leixcal][Hashtag] Fix prevSibling not getting updated after replacement of match as followup #6053 #6067

Merged
merged 5 commits into from
May 9, 2024
Merged

[Leixcal][Hashtag] Fix prevSibling not getting updated after replacement of match as followup #6053 #6067

merged 5 commits into from
May 9, 2024

Conversation

Sahejkm
Copy link
Contributor

@Sahejkm Sahejkm commented May 9, 2024 •
edited
Loading

@vercel Vercel
Copy link

vercel bot commented May 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 4:13pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 4:13pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 23.75 KB (0%) 475 ms (0%) 487 ms (+31.37% 🔺) 962 ms
packages/lexical-rich-text/dist/LexicalRichText.js 34.28 KB (0%) 686 ms (0%) 1.2 s (+2.78% 🔺) 1.8 s
packages/lexical-plain-text/dist/LexicalPlainText.js 34.3 KB (0%) 686 ms (0%) 1.3 s (+19.67% 🔺) 2 s

@Sahejkm Sahejkm mentioned this pull request May 9, 2024
Merged
zurfyx
zurfyx previously approved these changes May 9, 2024
View reviewed changes
@Sahejkm Sahejkm requested a review from zurfyx May 9, 2024 16:16
@Sahejkm Sahejkm merged commit 55a9c94 into main May 9, 2024
45 checks passed
@Sahejkm Sahejkm deleted the fix_prev_sibling_update_hashtag_issue branch May 9, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zurfyx zurfyx zurfyx approved these changes

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

@ivailop7 ivailop7 Awaiting requested review from ivailop7 ivailop7 is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sahejkm @zurfyx @facebook-github-bot