Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lexical-playground] Bug Fix: Emoji menu item not getting targeted styles #6055

Merged
merged 1 commit into from
May 13, 2024

Conversation

daltnd
Copy link
Contributor

@daltnd daltnd commented May 8, 2024

Description

Menu items in the emoji picker weren't getting the expected border radius styles on selection. This PR removes the div that wrapped emoji menu items so the global li pseudo selectors can target the items.

Test plan

Before

CleanShot 2024-05-07 at 19 01 49@2x

After

CleanShot 2024-05-07 at 19 01 25@2x

Copy link

vercel bot commented May 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 5:14am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 5:14am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants