[lexical-table][lexical-playground] Bug Fix: Table selection stuck #6049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderReznik
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz and
ivailop7
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
|
@AlexanderReznik on manually testing, it does work in Safari on a Mac as well, but the issue seems to be indeed a test thing with WebKit, since it consistently fails on the same DraggableBlock, it's possible it's indeed a correct failure. Maybe worth taking inspiration from the DraggableBlock tests to implement the ones here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prevents table selection from being stuck.
The problem is wrong order of handling the mouse events.
mouseupcan happen beforemousedownhandler added a handler formouseup. This leaves the editor in a state of selecting.This PR adds clean up logic into
mousemoveto prevent selection being stuckThe modification of
dragMouseis required for tests to pass, as it seems that this bug contributed to the successful execution of some testBefore