Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lexical-playground] Chore: add test for pasting over mentions #6024

Merged
merged 3 commits into from
May 29, 2024
Merged

[lexical-playground] Chore: add test for pasting over mentions #6024

merged 3 commits into from
May 29, 2024

Conversation

potatowagon
Copy link
Contributor

@potatowagon potatowagon commented May 4, 2024 •
edited
Loading

Description

add an e2e test for pasting over mentions. part of a sev followup task for lexical crashing when pasting over mentions. fix was in #5954

Test plan

npm run start & npm run test-e2e-chromium

Screenshot 2024-05-23 at 12 33 36 PM

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 4, 2024
@vercel Vercel
Copy link

vercel bot commented May 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 9:49am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 9:49am

@github-actions GitHub Actions
Copy link

github-actions bot commented May 4, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 23.93 KB (0%) 479 ms (0%) 311 ms (+455.07% 🔺) 790 ms
packages/lexical-rich-text/dist/LexicalRichText.js 34.59 KB (0%) 692 ms (0%) 461 ms (+209% 🔺) 1.2 s
packages/lexical-plain-text/dist/LexicalPlainText.js 34.59 KB (0%) 692 ms (0%) 340 ms (+97.37% 🔺) 1.1 s

@potatowagon potatowagon marked this pull request as draft May 4, 2024 08:21
@zurfyx
Copy link
Member

zurfyx commented May 4, 2024

Thank you for following up on this 🙏

@potatowagon
Copy link
Contributor Author

potatowagon commented May 23, 2024 •
edited
Loading

@zurfyx im good to close this if unit test is prefered, we can discuss which unit test file would be best to put copy paste tests

@potatowagon potatowagon marked this pull request as ready for review May 23, 2024 04:36
zurfyx
zurfyx previously approved these changes May 24, 2024
View reviewed changes
@Sahejkm Sahejkm added the extended-tests Run extended e2e tests on a PR label May 24, 2024
@potatowagon potatowagon added this pull request to the merge queue May 29, 2024
Merged via the queue into main with commit 8c0ef8e May 29, 2024
38 checks passed
@potatowagon potatowagon deleted the mention-test branch May 29, 2024 05:49
This was referenced Jun 26, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sahejkm Sahejkm Sahejkm approved these changes

@zurfyx zurfyx zurfyx left review comments

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

@ivailop7 ivailop7 Awaiting requested review from ivailop7 ivailop7 is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@potatowagon @zurfyx @Sahejkm @facebook-github-bot