Clamp number of registered editor above 0 #6001
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
thegreatercurve
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz and
ivailop7
as code owners
acywatson
previously approved these changes
May 1, 2024
thegreatercurve
force-pushed
the
bug/multiple-editors
branch
from
0bb1d57
to
adef270
Compare
acywatson
approved these changes
May 1, 2024
|
We should probably have an invariant rather than just clamping, so we can more easily find any bad code that causes this condition. |
|
Closing in favour of #6003 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since #5070, there are certain circumstances in which the document counts for
rootElementsRegisteredcan fall below 0, especially ifremoveRootElementEventsis called more thanaddRemoveRootElementEvents.As number of registered root elements should never be fewer than 1 after
addRemoveRootElementEventsis called, and because the number of root elements should never be fewer than 0 whenremoveRootElementEventsis called, we should clamp these values.