Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the issue of playground crashing when the selected node contain… #5960

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Fixed the issue of playground crashing when the selected node contain… #5960

merged 1 commit into from
Apr 26, 2024

Conversation

i-tengfei
Copy link
Contributor

@i-tengfei i-tengfei commented Apr 25, 2024 •
edited
Loading

When the selected node contains HeadingNode or QuoteNode, the selected node will be replaced by ParagraphNode, and execution of selection.extract will crash.

Fix: #5849 (comment)

2024-04-25.17.07.44.mov

@i-tengfei
Fixed the issue of playground crashing when the selected node contain…
0039e52 
…s a heading node and click ClearFormating button.

When the selected node contains HeadingNode or QuoteNode, the selected node will be replaced by ParagraphNode, and execution of selection.extract will crash.
@vercel Vercel
Copy link

vercel bot commented Apr 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2024 8:59am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2024 8:59am

@facebook-github-bot
Copy link
Contributor

Hi @i-tengfei!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 25, 2024
ivailop7
ivailop7 approved these changes Apr 25, 2024
View reviewed changes
Copy link
Collaborator

@ivailop7 ivailop7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ivailop7 ivailop7 merged commit 77f6faf into facebook:main Apr 26, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivailop7 ivailop7 ivailop7 approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@i-tengfei @facebook-github-bot @ivailop7