-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(LexicalNode): fix inline decorator isSelected #5948
Merged
ivailop7
merged 5 commits into
facebook:main
from
jason89521:fix/lexical-node-isSelected
Jul 20, 2024
Merged
fix(LexicalNode): fix inline decorator isSelected #5948
ivailop7
merged 5 commits into
facebook:main
from
jason89521:fix/lexical-node-isSelected
Jul 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Apr 24, 2024
jason89521
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz and
ivailop7
as code owners
April 24, 2024 05:28
Hi! Thanks for the contribution! Can you pls write tests to cover this use case? |
@StyleT Hi, just a gentle nudge to see if you could take a moment to review this pull request when you have a chance. Thanks! |
size-limit report 📦
|
ivailop7
approved these changes
Jul 20, 2024
etrepum
added a commit
to etrepum/lexical
that referenced
this pull request
Aug 10, 2024
…heck with proper short-circuiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
extended-tests
Run extended e2e tests on a PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
I pressed
shift + ArrowLeft
at the beginning of the video, and then pressedBackSpace
to delete the selection. You can see the image node is selected, but when I deleted the selection, it didn't been deleted. Actually, the image node was not selected.At the second half of the video, I pressed
shift + ArrowRight
, the first image also showed that it was selected. However, the image node didn't been selected actually, so when I deleted the selection, the image node didn't been deleted.2024-04-24.1.01.56.mov
What
Beside checking whether the selection is collapsed, we should also check non-collapsed situation.
How
First, check whether the node is an inline decorator node.
Then check whether the anchor is before the focus.
Additional Information
After this pr:
2024-04-24.1.20.23.mov