fix(LexicalNode): fix inline decorator isSelected

[jason89521]

Why

I pressed shift + ArrowLeft at the beginning of the video, and then pressed BackSpace to delete the selection. You can see the image node is selected, but when I deleted the selection, it didn't been deleted. Actually, the image node was not selected.

At the second half of the video, I pressed shift + ArrowRight, the first image also showed that it was selected. However, the image node didn't been selected actually, so when I deleted the selection, the image node didn't been deleted.

2024-04-24.1.01.56.mov

What

Beside checking whether the selection is collapsed, we should also check non-collapsed situation.

How

First, check whether the node is an inline decorator node.

Then check whether the anchor is before the focus.

• If so
  • check whether the anchor at the element node's last offset
  • check whether the anchor's node is the decorator node's parent
  • check whether the decorator node is the last child
  • if the above 3 conditions are satisfied, return false
• else
  • check whether the focus at the element node's last offset
  • check whether the focus's node is the decorator node's parent
  • check whether the decorator node is the last child
  • if the above 3 conditions are satisfied, return false

Additional Information

After this pr:

2024-04-24.1.20.23.mov

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
lexical	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 20, 2024 11:33pm
lexical-playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 20, 2024 11:33pm

[StyleT]

Hi! Thanks for the contribution!

Can you pls write tests to cover this use case?

[jason89521]

@StyleT added in c1d6ada!

[jason89521]

@StyleT Hi, just a gentle nudge to see if you could take a moment to review this pull request when you have a chance. Thanks!

[github-actions]

size-limit report 📦

Path	Size
lexical - cjs	28.76 KB (0%)
lexical - esm	28.61 KB (0%)
@lexical/rich-text - cjs	37.2 KB (0%)
@lexical/rich-text - esm	28.21 KB (0%)
@lexical/plain-text - cjs	35.85 KB (0%)
@lexical/plain-text - esm	25.5 KB (0%)
@lexical/react - cjs	39.12 KB (0%)
@lexical/react - esm	29.49 KB (0%)