Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken style for node overrides example on docs #5890

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Fix broken style for node overrides example on docs #5890

merged 1 commit into from
Apr 15, 2024

Conversation

2wheeh
Copy link
Contributor

@2wheeh 2wheeh commented Apr 15, 2024

Styling for the example on node-replacement is broken.

Before

image

After

image

@vercel Vercel
Copy link

vercel bot commented Apr 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 2:00pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 2:00pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 15, 2024
potatowagon
potatowagon approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@potatowagon potatowagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice thanks for this fix 👍

@StyleT StyleT merged commit 9bda45c into facebook:main Apr 15, 2024
5 checks passed
@2wheeh 2wheeh deleted the node-overrides-example-size branch April 15, 2024 23:36
@acywatson acywatson mentioned this pull request Apr 16, 2024
Merged
@dmitrymarokhonov dmitrymarokhonov mentioned this pull request May 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potatowagon potatowagon potatowagon approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@2wheeh @potatowagon @StyleT @facebook-github-bot