Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with typeahead positioning #5859

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Conversation

thegreatercurve
Copy link
Contributor

@thegreatercurve thegreatercurve commented Apr 9, 2024

Added in #5791 this is causing some menus for the typeahead plugin to be rendered offscreen.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 9, 2024
Copy link

vercel bot commented Apr 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 9, 2024 9:47pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 9, 2024 9:47pm

Copy link

github-actions bot commented Apr 9, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 26.95 KB (0%) 539 ms (0%) 244 ms (+35.12% 🔺) 783 ms
packages/lexical-rich-text/dist/LexicalRichText.js 39.37 KB (0%) 788 ms (0%) 668 ms (+23.42% 🔺) 1.5 s
packages/lexical-plain-text/dist/LexicalPlainText.js 39.34 KB (0%) 787 ms (0%) 493 ms (-10.86% 🔽) 1.3 s

@thegreatercurve thegreatercurve merged commit 9b229cd into main Apr 9, 2024
45 checks passed
@thegreatercurve thegreatercurve deleted the bug/typeahead-positioning branch April 9, 2024 22:03
@ivailop7
Copy link
Collaborator

ivailop7 commented Apr 9, 2024

That's unfortunate, because my change fixed the context menu being rendered off screen when the playground was scrolled. The context menu is now broken again when the page is scrolled. So I guess we can't have it both ways 🤷🏻‍♂️

@thegreatercurve
Copy link
Contributor Author

That's unfortunate, because my change fixed the context menu being rendered off screen when the playground was scrolled. The context menu is now broken again when the page is scrolled. So I guess we can't have it both ways 🤷🏻‍♂️

I'll try to set aside some time and look into abstracting out useMenuAnchorRef into a separate hook, so we can have a separate internal version, if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants