Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #5663 styling from td not persisted on copy paste #5855

Merged
merged 3 commits into from
Apr 11, 2024
Merged

Fix #5663 styling from td not persisted on copy paste #5855

merged 3 commits into from
Apr 11, 2024

Conversation

Sahejkm
Copy link
Contributor

@Sahejkm Sahejkm commented Apr 9, 2024 •
edited
Loading

Before:

Screen.Recording.2024-04-09.at.5.01.51.PM.mov

After:

Screen.Recording.2024-04-09.at.5.01.24.PM.mov

closes #5663

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 9, 2024
@vercel Vercel
Copy link

vercel bot commented Apr 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 9, 2024 10:00am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 9, 2024 10:00am

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 26.95 KB (0%) 539 ms (0%) 60 ms (+216.61% 🔺) 599 ms
packages/lexical-rich-text/dist/LexicalRichText.js 39.37 KB (0%) 788 ms (0%) 119 ms (+64.85% 🔺) 907 ms
packages/lexical-plain-text/dist/LexicalPlainText.js 39.34 KB (0%) 787 ms (0%) 133 ms (+126.63% 🔺) 920 ms

zurfyx
zurfyx approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@zurfyx zurfyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we might eventually want to move most of the E2E tests in this file to unit, there is little value in a full E2E run -- like we did in here https://github.com/facebookexternal/Outline//blob/9f8419195176e44f5755ef087d989dabb524c5a4/packages/lexical-table/src/__tests__/unit/LexicalTableNode.test.ts#L71

@Sahejkm Sahejkm merged commit 1b04cf3 into main Apr 11, 2024
45 checks passed
@acywatson acywatson mentioned this pull request Apr 16, 2024
Merged
@Sahejkm Sahejkm mentioned this pull request May 13, 2024
Merged
Sahejkm added a commit that referenced this pull request May 13, 2024
@Sahejkm
[Lexical][Table Formatting Copy Paste] Move test from e2e to unit as …
64d61f3 
…followup on #5855  (#6093)
@dmitrymarokhonov dmitrymarokhonov mentioned this pull request May 19, 2024
Open
This was referenced Jun 26, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zurfyx zurfyx zurfyx approved these changes

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

@ivailop7 ivailop7 Awaiting requested review from ivailop7 ivailop7 is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: copy and pasting table cell does not contains individual cell text style
3 participants
@Sahejkm @zurfyx @facebook-github-bot