Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextNode support font-weight bold #5852

Merged
merged 1 commit into from
Apr 11, 2024
Merged

TextNode support font-weight bold #5852

merged 1 commit into from
Apr 11, 2024

Conversation

zurfyx
Copy link
Member

@zurfyx zurfyx commented Apr 9, 2024 •
edited
Loading

Turns out that Google Spreadsheets can return bold text in font-weight=bold that we weren't handling yet.

Screenshot 2024-04-09 at 12 26 47 PM 
<span
  style="font-size:10pt;font-family:Arial;font-style:normal;">df </span><span
  style="font-size:10pt;font-family:Arial;font-weight:bold;font-style:normal;">dasdf</span>

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 9, 2024
@vercel Vercel
Copy link

vercel bot commented Apr 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview Apr 9, 2024 4:29am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 9, 2024 4:29am

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 26.95 KB (+0.02% 🔺) 540 ms (+0.02% 🔺) 148 ms (-12.46% 🔽) 687 ms
packages/lexical-rich-text/dist/LexicalRichText.js 39.37 KB (+0.01% 🔺) 788 ms (+0.01% 🔺) 575 ms (+27.87% 🔺) 1.4 s
packages/lexical-plain-text/dist/LexicalPlainText.js 39.34 KB (+0.02% 🔺) 787 ms (+0.02% 🔺) 549 ms (+17.71% 🔺) 1.4 s

Sahejkm
Sahejkm approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@Sahejkm Sahejkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zurfyx zurfyx merged commit 70c785e into main Apr 11, 2024
45 checks passed
@zurfyx zurfyx deleted the font-weight-bold2 branch April 11, 2024 00:22
zurfyx added a commit that referenced this pull request Apr 11, 2024
@zurfyx
Revert "TextNode support font-weight bold (#5852)"
f0877b5 
This reverts commit 70c785e.
@acywatson acywatson mentioned this pull request Apr 16, 2024
Merged
@dmitrymarokhonov dmitrymarokhonov mentioned this pull request May 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sahejkm Sahejkm Sahejkm approved these changes

@ivailop7 ivailop7 ivailop7 approved these changes

@StyleT StyleT StyleT approved these changes

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zurfyx @StyleT @ivailop7 @Sahejkm @facebook-github-bot