Preserve selection in tables with open typeahead menu on vertical arrow key press #5820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serey-roth
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz and
ivailop7
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
serey-roth
force-pushed
the
serey/table/vertical-navigation
branch
from
e944c91
to
cab9f49
Compare
|
@ivailop7 Can you take a look at this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change prevents the table cell selection from changing on vertical arrow keys while a typeahead menu is open (Fix #5819).
Before
https://www.loom.com/share/92e75e1299434e62838bd40449b77083?sid=a82a72d8-03ea-42b9-ba46-d2431be5a2d2
After
https://www.loom.com/share/53579c647ae84429be68b264a44a50bf?sid=f7e29571-dfe1-45f7-bb02-b7ac2d211f33