Bump publish scripts to v4 #5817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ivailop7
commented
Apr 3, 2024
•
ivailop7
commented
- Bump to checkout@v4 and setup-node@v4, remove explicit node version specification, ie. take latest LTS by default (20 right now)
- Disable the nightly script, which was just creating a branch, but never actually published
- Add an extra 'npm install' after version bump in the package.json's in the versioning script, since currently, it creates an inconsistent package-lock.json and requires a manual run of 'npm install' for when 'npm ci' is run to be correct when tests kick off in the version PR.
ivailop7
requested review from
zurfyx,
fantactuka,
acywatson and
Fetz
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
thegreatercurve
approved these changes
Apr 3, 2024
StyleT
approved these changes
Apr 15, 2024
|
@ivailop7 shall we merge this? |
yes please |
seems like I've lost my merge privileges, maybe @acywatson or @zurfyx can help |
Gerard fixed my permissions. Will merge later today. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.