-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lexical] Add tests for HTMLConfig #5507
[lexical] Add tests for HTMLConfig #5507
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
a59613e
to
95827a7
Compare
95827a7
to
6d648cc
Compare
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that this adds tests but it does let you write incorrect code that passes the type checker because really what we would want to say is that the key and value of the map are related (something like forall T extends LexicalNode. [K: Klass<T>, V: (editor: LexicalEditor, target: T) => DOMExportOutput]
but I don't think it would be possible to express something like that directly with Map's type
@etrepum You are right. I reverted that and changed this PR to focus on adding unit tests for HTMLConfig. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
EDIT:
This adds tests for HTMLConfig