Add commandPriority option to LexicalMenu and dependent components

[huw]

Resolves #3714, which is a long-standing issue that multiple users seem to have faced. Previously, this repo has solved it by:

1. Setting all of the commands to COMMAND_PRIORITY_NORMAL (LexicalTypeaheadMenuPlugin - Increase priority for keyboard commands #2885)
2. Setting all of the commands to COMMAND_PRIORITY_CRITICAL (Typeaheads: Add scroll command and increase priority #3106)
3. Setting all of the commands to COMMAND_PRIORITY_LOW (Change command priority in typeahead #3441)

It is pretty clear that a more generic solution is needed. This PR adds a commandPriority prop to LexicalMenu and its dependent components, including:

• LexicalTypeaheadMenuPlugin (most often called out)
• LexicalNodeMenuPlugin
• LexicalContextMenuPlugin
• LexicalAutoEmbedPlugin (under menuCommandPriority, because this plugin registers an insertion command that should remain at COMMAND_PRIORITY_EDITOR)

Future changes should address:

1. Customising priority per-command (this is hard to implement today since commands don’t have string IDs in production builds)
2. Customising priority for all components in @lexical/react

However, since LexicalMenu has been repeatedly and specifically changed, IMO this PR has a higher cost-benefit than doing those immediately (although I’d love a maintainer’s thoughts!).

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
lexical	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 16, 2023 4:27am
lexical-playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 16, 2023 4:27am

[facebook-github-bot]

Hi @huw!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[acywatson]

Yea this makes sense to me. Not sure why we put this off so long.

[acywatson]

Seems to be fully backwards compat

[huw]

Do I need to get the build to green to merge this?

[acywatson]

Do I need to get the build to green to merge this?

Nope! All good. Thank you