Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap noopener for noreferrer #4690

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Swap noopener for noreferrer #4690

merged 1 commit into from
Jun 22, 2023

Conversation

acconrad
Copy link
Contributor

The use of noreferrer supersedes noopener and it implies its use. It is safer, more widely-supported, and expands the range of supported browsers from XSS target=_blank vulnerabilities. noopener should therefore be deprecated in favor of noreferrer whenever target=_blank and rel=noopener is used. Instances of rel="noopener noreferrer" are safe (at worst, redundant) and were not included in this PR.

@vercel
Copy link

vercel bot commented Jun 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 22, 2023 3:22am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 22, 2023 3:22am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 22, 2023
Copy link
Member

@zurfyx zurfyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! As discussed internally, this only applies to very old browsers for which Lexical does not guarantee to work correctly. However, this is a relatively straightforward fix with non meaningful trade-offs.

@zurfyx zurfyx merged commit 7d3f63e into facebook:main Jun 22, 2023
@zurfyx zurfyx mentioned this pull request Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants