Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add KEY_DOWN_COMMAND #3878

Merged
merged 3 commits into from
Feb 10, 2023
Merged

Add KEY_DOWN_COMMAND #3878

merged 3 commits into from
Feb 10, 2023

Conversation

trueadm
Copy link
Collaborator

@trueadm trueadm commented Feb 10, 2023

This enables people to listen to all keydown commands and block any further commands if they return true. This can be useful for controlling very specific use-cases rather than having to fight with a custom keydown event listener.

@vercel
Copy link

vercel bot commented Feb 10, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
lexical ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 10, 2023 at 0:40AM (UTC)
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 10, 2023 at 0:40AM (UTC)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 10, 2023
@github-actions
Copy link

github-actions bot commented Feb 10, 2023 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 25.97 KB (+0.07% 🔺) 520 ms (+0.07% 🔺) 84 ms (+9.08% 🔺) 604 ms
packages/lexical-rich-text/dist/LexicalRichText.js 36.72 KB (+0.09% 🔺) 735 ms (+0.09% 🔺) 104 ms (+27.44% 🔺) 838 ms
packages/lexical-plain-text/dist/LexicalPlainText.js 36.69 KB (+0.1% 🔺) 734 ms (+0.1% 🔺) 63 ms (-30.24% 🔽) 797 ms

thegreatercurve
thegreatercurve approved these changes Feb 10, 2023
View reviewed changes
Copy link
Contributor

@thegreatercurve thegreatercurve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding in the docs

@trueadm trueadm merged commit fad90c6 into main Feb 10, 2023
@trueadm trueadm deleted the Add-KEYDOWN-command branch February 10, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thegreatercurve thegreatercurve thegreatercurve approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@tylerjbainbridge tylerjbainbridge Awaiting requested review from tylerjbainbridge

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trueadm @thegreatercurve @facebook-github-bot