Improve table selection handling when there are no siblings #3051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
tylerjbainbridge
requested review from
trueadm,
zurfyx,
fantactuka,
acywatson and
thegreatercurve
as code owners
| @@ -916,6 +920,39 @@ export function applyTableHandlers( | |||
| $addHighlightStyleToTable(tableSelection); | |||
|
|
|||
| return true; | |||
| } else if (selectionIsInsideTable) { | |||
There was a problem hiding this comment.
This basically just checks if it's a range selection located inside of a table and if all of the cells are selected. If so, it converts the range selection to a grid selection.
fantactuka
reviewed
Sep 22, 2022
fantactuka
approved these changes
Sep 22, 2022
Merged
acywatson
pushed a commit
that referenced
this pull request
Oct 18, 2022
* Improve table selection handling when there are no siblings * Refine solution
thegreatercurve
pushed a commit
that referenced
this pull request
Nov 25, 2022
* Improve table selection handling when there are no siblings * Refine solution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
Screen.Recording.2022-09-22.at.1.03.52.PM.mov
After
Screen.Recording.2022-09-22.at.1.22.29.PM.mov