-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update collab docs #3033
Merged
Merged
Update collab docs #3033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fantactuka
commented
Sep 19, 2022
- Note regarding editor state for composer
- Newly added initialEditorState for collab plugin
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Sep 19, 2022
fantactuka
requested review from
trueadm,
zurfyx,
acywatson,
tylerjbainbridge and
thegreatercurve
as code owners
September 19, 2022 15:27
acywatson
approved these changes
Sep 19, 2022
acywatson
reviewed
Sep 19, 2022
const initialConfig = {...}; | ||
const initialConfig = { | ||
// NOTE: This is critical for collaboration plugin to set editor state to null. It | ||
// would indicate that editor it should not try to set any default state |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"...would indicate that the editor should not try..."
fantactuka
force-pushed
the
collab-docs
branch
from
September 19, 2022 15:40
74f3bce
to
43b67f4
Compare
Merged
acywatson
pushed a commit
that referenced
this pull request
Oct 18, 2022
thegreatercurve
pushed a commit
that referenced
this pull request
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.