Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture pendingDecorators after garbage collecting detached decorators #2999

Merged

Conversation

adri1wald
Copy link
Contributor

Fixes #2993

Have made changes as suggested by @trueadm. Cursory testing within our app suggests this change fixes the useEffect cleanup bug I noted in #2993, although I cannot speak to any other side effects it might have.

@facebook-github-bot
Copy link
Contributor

Hi @adri1wald!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@vercel
Copy link

vercel bot commented Sep 12, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
lexical ✅ Ready (Inspect) Visit Preview Sep 12, 2022 at 8:49PM (UTC)
lexical-playground ✅ Ready (Inspect) Visit Preview Sep 12, 2022 at 8:49PM (UTC)

@trueadm
Copy link
Collaborator

trueadm commented Sep 12, 2022

Awesome. Thanks for taking the time to do this! Mind signing the CLA too please?

@adri1wald
Copy link
Contributor Author

Signed bout 30 min ago! Think it's just taking its time to go through.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 12, 2022
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Copy link
Contributor

@fantactuka fantactuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@acywatson acywatson merged commit eafa5b3 into facebook:main Sep 13, 2022
acywatson added a commit that referenced this pull request Sep 13, 2022
* fix (#2956)

* Add table cell menu back (#2958)

* fix (#2957)

* fix typo on read-mode / edit-mode page (#2962)

Co-authored-by: Christian Ratz <[email protected]>

* Fix link breaking when formatting on (#2954)

* Fix link breaking when formatting on

* nodeFormat to const

* retry checks

* allow escaped markdown within TextFormatTransformer (#2964)

Co-authored-by: Christian Ratz <[email protected]>

* Fix bugs with isEditable (#2967)

* Fix bugs with isEditable

* Revise

* Add empty comment in front of 'export' in a bundled file (#2970)

* Automated releases (#2949)

* change to using package.json in root as pinned version

* wip automated release workflow with manual triggerl

* change release script

* Fix build script

* checkout new branch

* release on push to next

* no accidental releases

* release on push to latest

* fix yaml

* fix yaml

* fix yaml

* remove unnecessary

* remove unnecessary

* prettier

* Update collab errors, related cleanup (#2971)

* install (#2972)

* Improve docs around the React plugins page (#2976)

* Improve docs around the React plugins page

* Improve docs around the React plugins page

* config (#2977)

* Clean up redundant newlines during pasting (#2969)

* Cleanup newlines unless its preformatted element

* Update docs

* push config (#2979)

* add ssh key

* add back config

* merge from main

* merge from main

* fix versioning for ff merge (#2983)

* remove ff merge from release (#2984)

* Fixed exportDOM for paragraph node (#2981)

* export DOM for paragraph node

* Fixed export DOM for paragraph node

* docs: Fix URL of rich-text and plain-text (#2985)

* docs: loadContent clarification (#2989)

* Fix insert column header bug (#2995)

* Fix WWW import rewrite for React (#2996)

* bad toc types

* fix react rename

* Fix www exports (#2994)

* [Automated Releases] Add logging and dry run to release script (#2986)

* add logs to release script

* add dry run to release script

* adjust dry run script

* add tag

* dont paginate changelog output

* auto-update changelog

* fix changelog

* fix import

* async

* cleanup

* fix

* fix

* Add DEPRECATED prefix to Grid APIs (#2966)

* Rm unused helpers from older markdown code (#2998)

* ElementNode -> isTopLevel() (#3001)

* Capture pendingDecorators after garbage collecting detached decorators (#2999)

* v0.4.2-next.0

Co-authored-by: Tyler Bainbridge <[email protected]>
Co-authored-by: Christian Ratz <[email protected]>
Co-authored-by: Christian Ratz <[email protected]>
Co-authored-by: Patrick McCullough <[email protected]>
Co-authored-by: Dominic Gannaway <[email protected]>
Co-authored-by: Maksim Horbachevsky <[email protected]>
Co-authored-by: Hafiz <[email protected]>
Co-authored-by: kimulaco <[email protected]>
Co-authored-by: ly3xqhl8g9 <[email protected]>
Co-authored-by: Gerard Rovira <[email protected]>
Co-authored-by: Adrien Wald <[email protected]>
Co-authored-by: Lexical GitHub Actions Bot <>
@zurfyx zurfyx mentioned this pull request Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: DecoratorNode's component does not call useEffect cleanup until after remount
5 participants