Capture pendingDecorators after garbage collecting detached decorators #2999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adri1wald
requested review from
trueadm,
zurfyx,
fantactuka,
acywatson,
tylerjbainbridge and
thegreatercurve
as code owners
|
Hi @adri1wald! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
trueadm
approved these changes
Sep 12, 2022
|
Awesome. Thanks for taking the time to do this! Mind signing the CLA too please? |
|
Signed bout 30 min ago! Think it's just taking its time to go through. |
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
acywatson
added a commit
that referenced
this pull request
Sep 13, 2022
* fix (#2956) * Add table cell menu back (#2958) * fix (#2957) * fix typo on read-mode / edit-mode page (#2962) Co-authored-by: Christian Ratz <[email protected]> * Fix link breaking when formatting on (#2954) * Fix link breaking when formatting on * nodeFormat to const * retry checks * allow escaped markdown within TextFormatTransformer (#2964) Co-authored-by: Christian Ratz <[email protected]> * Fix bugs with isEditable (#2967) * Fix bugs with isEditable * Revise * Add empty comment in front of 'export' in a bundled file (#2970) * Automated releases (#2949) * change to using package.json in root as pinned version * wip automated release workflow with manual triggerl * change release script * Fix build script * checkout new branch * release on push to next * no accidental releases * release on push to latest * fix yaml * fix yaml * fix yaml * remove unnecessary * remove unnecessary * prettier * Update collab errors, related cleanup (#2971) * install (#2972) * Improve docs around the React plugins page (#2976) * Improve docs around the React plugins page * Improve docs around the React plugins page * config (#2977) * Clean up redundant newlines during pasting (#2969) * Cleanup newlines unless its preformatted element * Update docs * push config (#2979) * add ssh key * add back config * merge from main * merge from main * fix versioning for ff merge (#2983) * remove ff merge from release (#2984) * Fixed exportDOM for paragraph node (#2981) * export DOM for paragraph node * Fixed export DOM for paragraph node * docs: Fix URL of rich-text and plain-text (#2985) * docs: loadContent clarification (#2989) * Fix insert column header bug (#2995) * Fix WWW import rewrite for React (#2996) * bad toc types * fix react rename * Fix www exports (#2994) * [Automated Releases] Add logging and dry run to release script (#2986) * add logs to release script * add dry run to release script * adjust dry run script * add tag * dont paginate changelog output * auto-update changelog * fix changelog * fix import * async * cleanup * fix * fix * Add DEPRECATED prefix to Grid APIs (#2966) * Rm unused helpers from older markdown code (#2998) * ElementNode -> isTopLevel() (#3001) * Capture pendingDecorators after garbage collecting detached decorators (#2999) * v0.4.2-next.0 Co-authored-by: Tyler Bainbridge <[email protected]> Co-authored-by: Christian Ratz <[email protected]> Co-authored-by: Christian Ratz <[email protected]> Co-authored-by: Patrick McCullough <[email protected]> Co-authored-by: Dominic Gannaway <[email protected]> Co-authored-by: Maksim Horbachevsky <[email protected]> Co-authored-by: Hafiz <[email protected]> Co-authored-by: kimulaco <[email protected]> Co-authored-by: ly3xqhl8g9 <[email protected]> Co-authored-by: Gerard Rovira <[email protected]> Co-authored-by: Adrien Wald <[email protected]> Co-authored-by: Lexical GitHub Actions Bot <>
Merged
acywatson
pushed a commit
that referenced
this pull request
Oct 18, 2022
thegreatercurve
pushed a commit
that referenced
this pull request
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2993
Have made changes as suggested by @trueadm. Cursory testing within our app suggests this change fixes the useEffect cleanup bug I noted in #2993, although I cannot speak to any other side effects it might have.