Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure editor states are cloned if read only #2936

Merged
merged 1 commit into from
Sep 2, 2022
Merged

Ensure editor states are cloned if read only #2936

merged 1 commit into from
Sep 2, 2022

Conversation

trueadm
Copy link
Collaborator

@trueadm trueadm commented Sep 2, 2022

If not, we'll hit an invariant!

@vercel
Copy link

vercel bot commented Sep 2, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
lexical ✅ Ready (Inspect) Visit Preview Sep 2, 2022 at 1:52PM (UTC)
lexical-playground ✅ Ready (Inspect) Visit Preview Sep 2, 2022 at 1:52PM (UTC)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 2, 2022
@trueadm trueadm marked this pull request as ready for review September 2, 2022 13:50
@trueadm trueadm merged commit 7165f8a into main Sep 2, 2022
@trueadm trueadm deleted the fix-readonly-issue branch September 2, 2022 19:31
thegreatercurve pushed a commit that referenced this pull request Nov 25, 2022
@trueadm @thegreatercurve
Ensure editor states are cloned if read only (#2936)
30efd10
@thegreatercurve thegreatercurve mentioned this pull request Nov 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thegreatercurve thegreatercurve thegreatercurve approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@tylerjbainbridge tylerjbainbridge Awaiting requested review from tylerjbainbridge

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trueadm @thegreatercurve @facebook-github-bot