Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant readonly checks. #2921

Merged
merged 4 commits into from
Aug 31, 2022
Merged

Remove redundant readonly checks. #2921

merged 4 commits into from
Aug 31, 2022

Conversation

acywatson
Copy link
Contributor

One thing I discovered in exploring readOnly is that a lot of these checks are redundant, since we already check readOnly in the getWritable method.

@vercel
Copy link

vercel bot commented Aug 31, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
lexical ✅ Ready (Inspect) Visit Preview Aug 31, 2022 at 8:16PM (UTC)
lexical-playground ✅ Ready (Inspect) Visit Preview Aug 31, 2022 at 8:16PM (UTC)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 31, 2022
@acywatson acywatson merged commit ea91e49 into main Aug 31, 2022
thegreatercurve pushed a commit that referenced this pull request Nov 25, 2022
* allow selection in readonly mode

* prevent non-collab updates in readonly mode

* remove redundant readOnly checks

* remove code
@trueadm trueadm deleted the read-only-updates branch December 18, 2022 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants