Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serialized node type exports #2914

Conversation

matthew-plusprogramming
Copy link
Contributor

@matthew-plusprogramming matthew-plusprogramming commented Aug 31, 2022

Sorry if the similar PR to #2894 is bad practice, I'm new to contributing to OSS. The reason for this new PR is I changed the merge source branch name to reflect the changes now being made compared to previous changes.

@vercel
Copy link

vercel bot commented Aug 31, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
lexical ❌ Failed (Inspect) Aug 31, 2022 at 5:18AM (UTC)
lexical-playground ❌ Failed (Inspect) Aug 31, 2022 at 5:18AM (UTC)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 31, 2022
@matthew-plusprogramming
Copy link
Contributor Author

Carried over from the old PR:

The SerializedParagraphNode and SerializedLineBreakNode types are already being exported in their respective files. If I'm missing anything still, please let me know!

@matthew-plusprogramming matthew-plusprogramming changed the title Add SerializedParagraphNode and SerializedLineBreakNode type exports Add serialized node type exports Aug 31, 2022
@thegreatercurve
Copy link
Contributor

@matthew-plusprogramming The tests are failing because you need to rebase this on top of main. I'm happy to merge this without waiting though because it only contains type exports.

@thegreatercurve thegreatercurve merged commit 5eb1907 into facebook:main Aug 31, 2022
thegreatercurve pushed a commit that referenced this pull request Nov 25, 2022
* Add `SerializedParagraphNode` and `SerializedLineBreakNode` type exports

* Add `SerializedListItemNode` and `SerializedListNode` type exports

* Add `SerializedMarkNode` type export
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants