-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced addTransform
with registerNodeTransform
in transforms doc
#2882
Replaced addTransform
with registerNodeTransform
in transforms doc
#2882
Conversation
`addTransform` was renamed a couple of times (first to `addNodeTransform` then `registerNodeTransform`) but the doc page on transforms still referenced the original naming.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Something for a separate issue - it's not entirely clear what "rules 2 and 1" refers to in the "You move a node via |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
@@ -107,7 +107,7 @@ You remove a node, its parent is marked dirty, also the node's immediate sibling | |||
You move a node via `replace`, rules 2 and 1 are applied. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't even know what this is too, must have been a typo. We can probably remove this line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably refers to the previous two lines?
Thank you! |
#2882) `addTransform` was renamed a couple of times (first to `addNodeTransform` then `registerNodeTransform`) but the doc page on transforms still referenced the original naming.
addTransform
was renamed a couple of times (first toaddNodeTransform
thenregisterNodeTransform
) but the doc page on transforms still referenced the original naming.