Replaced addTransform with registerNodeTransform in transforms doc
#2882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`addTransform` was renamed a couple of times (first to `addNodeTransform` then `registerNodeTransform`) but the doc page on transforms still referenced the original naming.
kevinansfield
requested review from
trueadm,
zurfyx,
fantactuka,
acywatson,
tylerjbainbridge and
thegreatercurve
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
|
Something for a separate issue - it's not entirely clear what "rules 2 and 1" refers to in the "You move a node via |
trueadm
reviewed
Aug 24, 2022
| @@ -107,7 +107,7 @@ You remove a node, its parent is marked dirty, also the node's immediate sibling | |||
| You move a node via `replace`, rules 2 and 1 are applied. | |||
There was a problem hiding this comment.
I don't even know what this is too, must have been a typo. We can probably remove this line.
There was a problem hiding this comment.
Probably refers to the previous two lines?
|
Thank you! |
thegreatercurve
pushed a commit
that referenced
this pull request
Nov 25, 2022
#2882) `addTransform` was renamed a couple of times (first to `addNodeTransform` then `registerNodeTransform`) but the doc page on transforms still referenced the original naming.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addTransformwas renamed a couple of times (first toaddNodeTransformthenregisterNodeTransform) but the doc page on transforms still referenced the original naming.