-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exported DEFAULT_TRANSFORMERS array in react LexicalMarkdownShortcutPlugin #2878
Exported DEFAULT_TRANSFORMERS array in react LexicalMarkdownShortcutPlugin #2878
Conversation
Hi @kevinansfield! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Could you add it to .flow/.d.ts for proper exports typing |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
…lugin The `LexicalMarkdownShortcutPlugin` package extends the defaults from `@lexical/markdown` with a HR transform but didn't expose that default list making it harder for anyone wanting to use the defaults plus their own extensions.
83de9a5
to
90cb46e
Compare
@fantactuka I've just added it to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Thanks! |
…lugin (#2878) The `LexicalMarkdownShortcutPlugin` package extends the defaults from `@lexical/markdown` with a HR transform but didn't expose that default list making it harder for anyone wanting to use the defaults plus their own extensions.
The
LexicalMarkdownShortcutPlugin
package extends the defaults from@lexical/markdown
with a HR transform but didn't expose that default list making it harder for anyone wanting to use the defaults plus their own extensions.