Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exported DEFAULT_TRANSFORMERS array in react LexicalMarkdownShortcutPlugin #2878

Merged

Conversation

kevinansfield
Copy link
Collaborator

The LexicalMarkdownShortcutPlugin package extends the defaults from @lexical/markdown with a HR transform but didn't expose that default list making it harder for anyone wanting to use the defaults plus their own extensions.

@facebook-github-bot
Copy link
Contributor

Hi @kevinansfield!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@vercel
Copy link

vercel bot commented Aug 23, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
lexical ✅ Ready (Inspect) Visit Preview Aug 23, 2022 at 6:59PM (UTC)
lexical-playground ✅ Ready (Inspect) Visit Preview Aug 23, 2022 at 6:59PM (UTC)

@fantactuka
Copy link
Contributor

Could you add it to .flow/.d.ts for proper exports typing

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 23, 2022
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

…lugin

The `LexicalMarkdownShortcutPlugin` package extends the defaults from `@lexical/markdown` with a HR transform but didn't expose that default list making it harder for anyone wanting to use the defaults plus their own extensions.
@kevinansfield
Copy link
Collaborator Author

Could you add it to .flow/.d.ts for proper exports typing

@fantactuka I've just added it to flow/LexicalMarkdownShortcutPlugin.js.flow, is that what you meant? Sorry, I'm completely new to flow so wasn't aware it was needed 🙂

Copy link
Member

@zurfyx zurfyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@acywatson
Copy link
Contributor

Thanks!

@acywatson acywatson merged commit 328e63c into facebook:main Aug 24, 2022
thegreatercurve pushed a commit that referenced this pull request Nov 25, 2022
…lugin (#2878)

The `LexicalMarkdownShortcutPlugin` package extends the defaults from `@lexical/markdown` with a HR transform but didn't expose that default list making it harder for anyone wanting to use the defaults plus their own extensions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants