Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small toolbar style fix #2848

Merged
merged 1 commit into from
Aug 18, 2022
Merged

Small toolbar style fix #2848

merged 1 commit into from
Aug 18, 2022

Conversation

thegreatercurve
Copy link
Contributor

@thegreatercurve thegreatercurve commented Aug 18, 2022 •
edited
Loading

The toolbar sometimes shows it's scrollbar at max width if the first dropdown contains a long enough string #2848

Fixes the below:

image

@vercel
Copy link

vercel bot commented Aug 18, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
lexical ✅ Ready (Inspect) Visit Preview Aug 18, 2022 at 2:17PM (UTC)
lexical-playground ✅ Ready (Inspect) Visit Preview Aug 18, 2022 at 2:17PM (UTC)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 18, 2022
@thegreatercurve thegreatercurve changed the title The toolbar sometimes shows it's scrollbar at max width if the first dropdown contains a long enough string Small toolbar style fix Aug 18, 2022
@fantactuka
Copy link
Contributor

fantactuka commented Aug 18, 2022 •
edited
Loading

We might need to consider nested dropdowns at this point 😁
Not sure if it's still the case, but some collab tests failed in the past as it wasn't able to click on right-most dropdown (as it's using split view to show two editors). In that case will need to increase playwright browser's start width to be maxWidth x2

@thegreatercurve
Copy link
Contributor Author

We might need to consider nested dropdowns at this point 😁

@fantactuka Yeah, I'm starting to think we should have several smaller playgrounds with different examples than our one kitchen sink example. This is somtehing other editors do better.

@thegreatercurve thegreatercurve merged commit 7fde2ed into main Aug 18, 2022
@thegreatercurve thegreatercurve deleted the bug/small-playrground-styling-issue branch August 18, 2022 16:04
thegreatercurve added a commit that referenced this pull request Nov 25, 2022
@thegreatercurve
Wider (#2848)
03fca5f
@thegreatercurve thegreatercurve mentioned this pull request Nov 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fantactuka fantactuka fantactuka approved these changes

@trueadm trueadm Awaiting requested review from trueadm

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@tylerjbainbridge tylerjbainbridge Awaiting requested review from tylerjbainbridge

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thegreatercurve @fantactuka @facebook-github-bot