fixed getStyleObjectFromRawCSS to handle css values with a colon #2814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosatross
requested review from
trueadm,
zurfyx,
fantactuka,
acywatson,
tylerjbainbridge and
thegreatercurve
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
|
Nice, thanks for writing a test! |
acywatson
reviewed
Aug 11, 2022
| const patch = style.split(':'); | ||
| styleObject[patch[0].trim()] = patch[1].trim(); | ||
| const [key, ...value] = style.split(':'); | ||
| styleObject[key.trim()] = value.join(':').trim(); |
There was a problem hiding this comment.
I guess another way to go at this would be Regex capture groups, which might be more performant than all this string manipulation. Thoughts?
There was a problem hiding this comment.
im not great with regex but gave it a go - lmk what you think
There was a problem hiding this comment.
Great catch, the regex version looks much cleaner!
acywatson
approved these changes
Aug 12, 2022
acywatson
reviewed
Aug 12, 2022
| @@ -310,8 +310,8 @@ function getStyleObjectFromRawCSS(css: string): Record<string, string> { | |||
|
|
|||
| for (const style of styles) { | |||
| if (style !== '') { | |||
| const patch = style.split(':'); | |||
| styleObject[patch[0].trim()] = patch[1].trim(); | |||
| const [key, value] = style.split(/:([^]+)/); // split on first colon | |||
There was a problem hiding this comment.
I had actually forgotten you could use the "^" character this way in JS RegEx!
thegreatercurve
pushed a commit
that referenced
this pull request
Nov 25, 2022
* fixed getStyleObjectFromRawCSS to handle css values with a colon * use regex instead of string manipulation * add test cases * prettier formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if a css property has a colon in its value the rest of the value following the colon gets cut off.
Ran into this when using a font family with a prefix e.g.
font-family: prefix:Arial