$insertNodes: Selection-agnostic node insertion with Grid/Node selection support #2638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zurfyx
requested review from
trueadm,
fantactuka,
acywatson,
tylerjbainbridge and
thegreatercurve
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
acywatson
reviewed
Jul 13, 2022
| useEffect(() => { | ||
| hasModifier.current = false; | ||
| const handler = (e: KeyboardEvent) => { | ||
| // debugger; |
acywatson
reviewed
Jul 13, 2022
| @@ -84,3 +84,65 @@ export function $normalizeTextNode(textNode: TextNode): void { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| export function $normalizeSelection(selection: RangeSelection): RangeSelection { | |||
There was a problem hiding this comment.
Do we need a whole separate module in core for this? What else will go in here?
There was a problem hiding this comment.
Hmm, what do you mean by a new module? It has $canSimpleTextNodesBeMerged, $mergeTextNodes and $normalizeTextNode. It just felt like a good fit for another normalization function
There was a problem hiding this comment.
Oh lol I never knew we had a LexicalNormalization module so I assumed you created it. #til
|
This looks awesome! Planning to step through this logic a bit more later, maybe a comment or two on the normalization logic would be good? |
thegreatercurve
approved these changes
Jul 14, 2022
acywatson
approved these changes
Jul 18, 2022
Also stop using that podcast tweet as test data lol |
Merged
acywatson
pushed a commit
that referenced
this pull request
Oct 18, 2022
thegreatercurve
pushed a commit
that referenced
this pull request
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node selection
Screen.Recording.2022-07-13.at.3.37.18.pm.mov
Grid selection
Screen.Recording.2022-07-13.at.3.38.46.pm.mov