chore: add e2e tests for maxlength plugin #2478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
im-adithya
requested review from
trueadm,
zurfyx,
fantactuka,
acywatson,
tylerjbainbridge and
thegreatercurve
as code owners
facebook-github-bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thegreatercurve
requested changes
Jun 20, 2022
fantactuka
approved these changes
Jun 22, 2022
|
Somehow messed up with tabs and pressed approve in a wrong one 🤷♂️ John's change request makes sense |
im-adithya
force-pushed
the
task-add-tests
branch
from
6c80219
to
7323182
Compare
|
Fixed! I wasn't using focusEditor in collab mode which caused the error. This same test was passing before I added the But I can't seem to reproduce this in my localhost (in firefox)... And this error doesn't seem to occur in mac. Why is this happening? |
thegreatercurve
approved these changes
Jun 27, 2022
thegreatercurve
force-pushed
the
task-add-tests
branch
from
7323182
to
b37f931
Compare
|
Looks like we still have failing tests here |
im-adithya
force-pushed
the
task-add-tests
branch
from
b37f931
to
0ed5aaf
Compare
|
@acywatson @thegreatercurve ready to merge! |
thegreatercurve
pushed a commit
that referenced
this pull request
Nov 25, 2022
* chore: add e2e tests for maxlength plugin * fix * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #2467 which failed e2e