-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add e2e tests for maxlength plugin #2478
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually looks like there may be a bug with the plugin or the E2Es. Some of these E2Es are failing legitimately.
Somehow messed up with tabs and pressed approve in a wrong one 🤷♂️ John's change request makes sense |
6c80219
to
7323182
Compare
Fixed! I wasn't using focusEditor in collab mode which caused the error.
This same test was passing before I added the But I can't seem to reproduce this in my localhost (in firefox)... And this error doesn't seem to occur in mac. Why is this happening? |
7323182
to
b37f931
Compare
Looks like we still have failing tests here |
b37f931
to
0ed5aaf
Compare
@acywatson @thegreatercurve ready to merge! |
* chore: add e2e tests for maxlength plugin * fix * fix
Follow up to #2467 which failed e2e