Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add e2e tests for MaxLength plugin #2466

Merged
merged 1 commit into from
Jun 17, 2022
Merged

add e2e tests for MaxLength plugin #2466

merged 1 commit into from
Jun 17, 2022

Conversation

im-adithya
Copy link
Contributor

Follow up to #2296, as suggested by #2296 (review)
(as the issue is fixed by #2428)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 17, 2022
@vercel
Copy link

vercel bot commented Jun 17, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
lexical ✅ Ready (Inspect) Visit Preview Jun 17, 2022 at 4:17PM (UTC)
lexical-playground ✅ Ready (Inspect) Visit Preview Jun 17, 2022 at 4:17PM (UTC)

zurfyx
zurfyx approved these changes Jun 17, 2022
View reviewed changes
Copy link
Member

@zurfyx zurfyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I believe that another interesting case would be pasting 💏 at the edge (like the lorem ipsum at L84) but that's a solid test already

@zurfyx zurfyx merged commit e5b574d into facebook:main Jun 17, 2022
zurfyx added a commit that referenced this pull request Jun 17, 2022
@zurfyx
Revert "add e2e tests for MaxLength plugin (#2466)"
ec19bde 
This reverts commit e5b574d.
zurfyx added a commit that referenced this pull request Jun 17, 2022
@zurfyx
Revert "add e2e tests for MaxLength plugin (#2466)" (#2467)
8652e94 
This reverts commit e5b574d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zurfyx zurfyx zurfyx approved these changes

@trueadm trueadm Awaiting requested review from trueadm

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@tylerjbainbridge tylerjbainbridge Awaiting requested review from tylerjbainbridge

@thegreatercurve thegreatercurve Awaiting requested review from thegreatercurve

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@im-adithya @zurfyx @facebook-github-bot