Don't insert blank lines between line comments at the end of files

[nreid260]

There was already code/testing for this, but it wasn't covering a strange case where a comment was the first line of the file.

[nreid260]

@cgrushko

[cgrushko]

heh, we didn't feel this internally because we have a blank line between the first line (comment) and the package statement :)
Can you add a test that makes sure that an existing blank line is preserved?

[facebook-github-bot]

@cgrushko has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[nreid260]

heh, we didn't feel this internally because we have a blank line between the first line (comment) and the package statement :) Can you add a test that makes sure that an existing blank line is preserved?

Done

[facebook-github-bot]

@cgrushko has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[cgrushko]

Apologies for the delay, everybody seems to be unavailable this week at the same time :(

[nreid260]

Yeah, I know the feeling. Here too.

[facebook-github-bot]

@cgrushko merged this pull request in b6e5f35.

[hick209]

Overall this looks like a good improvement.
In our tests to see what changes though, we found this regression.

With this change this code here, which should not be touched

// License

package /* comment */ com.example.ktfmt /* comment */

import com.example.ImportOne
import com.example.ImportTwo
// ...

Gets formatted to this – removing empty line separating package declaration and imports

// License

package /* comment */ com.example.ktfmt /* comment */
import com.example.ImportOne
import com.example.ImportTwo
// ...

Could you take a look into this?