Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve spec text from #138 #142

Merged
merged 1 commit into from
Feb 28, 2022
Merged

Improve spec text from #138 #142

merged 1 commit into from
Feb 28, 2022

Conversation

Huxpro
Copy link
Contributor

@Huxpro Huxpro commented Feb 28, 2022 •
edited
Loading

Some improvements to #138

  • move SS: early error specific to JSXElement production under JSXElement clause
  • improve the phrasing on grammar parameterization.

cc @Jack-Works in case he has any inputs but I'll merge first to unblock #136

@Huxpro Huxpro merged commit c1537c1 into facebook:main Feb 28, 2022
Jack-Works
Jack-Works reviewed Mar 1, 2022
View reviewed changes
Copy link
Contributor

@Jack-Works Jack-Works left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jack-Works Jack-Works Jack-Works left review comments

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Huxpro @Jack-Works @facebook-github-bot