Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix processes count and chunk size for run-in-band mode #96

Merged
merged 1 commit into from
Mar 14, 2016
Merged

Fix processes count and chunk size for run-in-band mode #96

merged 1 commit into from
Mar 14, 2016

Conversation

zertosh
Copy link
Member

@zertosh zertosh commented Mar 14, 2016

The worker was being called more than once when in run-in-band mode.

fkling added a commit that referenced this pull request Mar 14, 2016
Fix processes count and chunk size for run-in-band mode
@fkling fkling merged commit ec7c101 into facebook:master Mar 14, 2016
@fkling
Copy link
Contributor

fkling commented Mar 15, 2016

Released with v0.3.15.

euphocat pushed a commit to euphocat/jscodeshift that referenced this pull request Oct 22, 2017
…acebook#96)

* Don't put comments on JSXIdentifier nodes in create-element-to-jsx

Previously, this code:

```js
React.createElement(
  Foo, // This is a comment
  {bar: baz}
);
```

would change to this code:

```js
<// This is a comment
Foo bar={baz} />
```

This is technically correct, but really ugly, so this commit changes the script
to reposition the comment to be on the outer JSXElement instead of the
JSXIdentifier directly. As we traverse the first arg to `React.createElement`,
we collect all comments and add them to the array of comments that we'll
eventually add to the outer JSXElement.

Note that this depends on a fix to recast that was just released in version
0.11.22. See this PR for more details: benjamn/recast#364
Without that change, the repositioned comment could sometimes cause the
resulting code to be incorrect if it's at the start of the expression part of a
return statement. The latest jscodeshift has recast 0.11.22 in its version
range, so a fresh install makes everything work, but an old install might fail.

* Update jscodeshift in package.json to try to get the build to work

Also alphabetize the dependencies since that's what `npm install --save` does.

* Update yarn.lock so recast gets updated

This was done with `yarn remove jscodeshift` and `yarn add jscodeshift`, so it
updated all jscodeshift dependencies to latest, including recast.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants