feat: add pkg.pr.new #622
feat: add pkg.pr.new #622
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This sounds useful. Do you have a demo of how it works? |
.github/workflows/cr.yml
Outdated
| - name: Install dependencies | ||
| run: yarn --frozen-lockfile | ||
| - name: Preview | ||
| run: npx pkg-pr-new publish --compact |
There was a problem hiding this comment.
We should lock this to a particular version or hash of pkg-pr-new so that we have to manually bump it to new versions. Running arbitrary new versions of this in a build script is a major supply chain attack risk.
Could you please add it as a dev dependency then run it with yarn, instead of using npx? That also avoids needing to have two package management systems installed (yarn and npm)
|
Amazing, I just moved to yarn now and installed pkg.pr.new! Would be happy to hear your thoughts! |
|
Sure, let's try it out! |
I sent a request for access (to the admins of the Facebook org on Github, I guess) since I don't have permission to do this myself. |
|
@Aslemammad Do you know what this error means?
I see that on this PR for example: #633 |
|
I see, have you installed the github application? |
|
Looks like this is working now. I had to get some issues fixed with the GitHub app. Test: #637 |
This PR adds continuous preview releases to jscodeshift!
Before running the workflow, we'd have to install the app!