Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use corepack for managing yarn version #599

Merged
merged 2 commits into from
Jul 15, 2024
Merged

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented Jul 15, 2024

Fixes: #598

Copy link

vercel bot commented Jul 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jscodeshift ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2024 3:20am

@Daniel15
Copy link
Member

Daniel15 commented Jul 15, 2024

The Node.js site says that Corepack is experimental: https://nodejs.org/api/corepack.html. Do you know if there's a risk of breaking changes that could cause issues, or a timeline for a stable release? The readme should probably also have non-Corepack instructions for people using older Node.js versions.

@trivikr
Copy link
Contributor Author

trivikr commented Jul 15, 2024

Do you know if there's a risk of breaking changes that could cause issues

If Node.js removes corepack, most developers on yarn will ideally switch to installing it globally using npm install -g corepack, and it'll work in the same way.

a timeline for a stable release?

No one knows. We've been trying to push since May'22 in nodejs/corepack#104, but Node.js TSC is not able to arrive at a decision.

The readme should probably also have non-Corepack instructions for people using older Node.js versions.

Corepack is available in all Node.js versions supported by jscodeshift. And these instructions are for contributors of jscodeshift, and not users.

@Daniel15
Copy link
Member

Sounds good to me! Thank you.

@Daniel15 Daniel15 merged commit 06493b7 into facebook:main Jul 15, 2024
6 checks passed
@Daniel15
Copy link
Member

@trivikr We should probably add an SHA hash as documented in the Corepack readme: https://github.com/nodejs/corepack?tab=readme-ov-file#when-authoring-packages to reduce the risk of supply chain attacks (having said that, I've been doing the Yarn 1.x packaging, and I trust myself 😛)

@trivikr
Copy link
Contributor Author

trivikr commented Jul 15, 2024

We should probably add an SHA hash as documented in the Corepack readme: https://github.com/nodejs/corepack?tab=readme-ov-file#when-authoring-packages

PR to add sha #602

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use corepack for managing yarn version
3 participants