hasAttributes filter method supports attributes with omitted boolean values #277
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves an issue when
JSXElement
'shasAttribute
filter method can't find attributes where boolean value (true
) was omitted.E.g., given this
jsx
:If I try to do something like this:
JSXElement
will throw an errorTypeError: Cannot read property 'expression' of null
since there is novalue
.jscodeshift/src/collections/JSXElement.js
Line 100 in 595b15c
balylon7 AST for above
jsx
code looks like this:I also ran
npm run docs
since I modified a few files, this produced lots of doc updates 😨Main changes are in
JSXElement.js
andJSXElement-test.js
files.