Fix message when changedSince is being used #7028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natealcedo
changed the title
Codecov Report
@@ Coverage Diff @@
## master #7028 +/- ##
==========================================
- Coverage 66.95% 66.95% -0.01%
==========================================
Files 250 250
Lines 10428 10430 +2
Branches 4 3 -1
==========================================
+ Hits 6982 6983 +1
- Misses 3445 3446 +1
Partials 1 1
Continue to review full report at Codecov.
|
SimenB
approved these changes
Sep 23, 2018
SimenB
reviewed
Sep 23, 2018
| @@ -5,7 +5,7 @@ | |||
| - `[pretty-format]` Option to not escape strings in diff messages ([#5661](https://github.com/facebook/jest/pull/5661)) | |||
| - `[jest-haste-map]` Add `getFileIterator` to `HasteFS` for faster file iteration ([#7010](https://github.com/facebook/jest/pull/7010)). | |||
| - `[jest-worker]` [**BREAKING**] Add functionality to call a `setup` method in the worker before the first call and a `teardown` method when ending the farm ([#7014](https://github.com/facebook/jest/pull/7014)). | |||
| - `[jest-config]` [**BREAKING**] Set default `notifyMode` to `faluire-change` ([#7024](https://github.com/facebook/jest/pull/7024)) | |||
| - `[jest-config]` [**BREAKING**] Set default `notifyMode` to `failure-change` ([#7024](https://github.com/facebook/jest/pull/7024)) | |||
|
Sweet. What a prompt response! 👍 |
natealcedo
commented
Sep 23, 2018
| @@ -177,10 +177,10 @@ export default class Runner extends EventEmitter { | |||
|
|
|||
| findMessageType(buf: Buffer): MessageType { | |||
| const str = buf.toString('utf8', 0, 58); | |||
| if (str === 'No tests found related to files changed since last commit.') { | |||
| const lastCommitRegex = /No tests found related to files changed since ((last commit)|([a-z0-9]+))./; | |||
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request makes a quality of life improvement as referred here (#7026). If a
changedSinceflag is being used, the test runner should update the message being shown to reflect the ref thatchangedSinceis being pointed to. This PR also updates the runner to be aware of this new message format.Test plan
I've added tests cases in https://github.com/facebook/jest/blob/master/e2e/__tests__/only_changed.test.js and https://github.com/facebook/jest/blob/master/packages/jest-editor-support/src/__tests__/runner.test.js to reflect the changes.