fix xdebug coverage (part1): xdebug_get_code_coverage
return value format for executed line
#7888
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is related to #1589 .
(I will submit another pull request for supporting
XDEBUG_CC_UNUSED
andXDEBUG_CC_DEAD_CODE
later)xdebug_get_code_coverage()
return value format is described in https://xdebug.org/docs/code_coverage :According to this description,
xdebug_get_code_coverage()
should return value like:However, hhvm's
xdebug_get_code_coverage()
currently returns value like:In this pull request, hhvm's
xdebug_get_code_coverage()
return value format for executed line is changed to follow description in https://xdebug.org/docs/code_coverage .