fix constructor param for FilterIterator

[danslo]

When grabbing the constructor arguments through reflection from the
FilterIterator class, HHVM accurately reports the parameter with name
'it' in accordance to both HHVM's FilterIterator.php and PHP's
filteriterator.inc(1).

PHP however, returns 'iterator'. I suspect this is a core PHP bug but I
am running this through you guys to see if this should be reported
upstream or if I am just imagining things.

For your information, the classes that do derive from FilterIterator
already take an 'iterator' param. In any case, attached is a patch
and testcase to make HHVM compatible with PHP, despite it doing crazy stuff.

1. https://github.com/php/php-src/blob/master/ext/spl/internal/filteriterator.inc#L35

[scannell]

How did you find this? (What code is relying upon it?) If PHP had a spec I'm inclined to agree with @kandy that I wouldn't expect the SPL argument names to be part of it.

[danslo]

I found it in the Magento2 codebase and it had to do with Zend code
generation (for a proxy class in this case). This is a very low prio ticket
for me, but was wondering what the appropriate path would be here.

I can give you more specific details this weekend so you can park it for
now.
On Jan 6, 2014 6:04 PM, "Sean Cannella" [email protected] wrote:

How did you find this? (What code is relying upon it?) If PHP had a spec
I'm inclined to agree with @kandy https://github.com/kandy that I
wouldn't expect the SPL argument names to be part of it.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1492#issuecomment-31665339
.

[scannell]

I'll park it for now. Does Magento2 have to rely on this and can it instead only depend on sequence? (I think there's going to be a lot of these and given Zend docs != Zend code it's unclear what the "correct" behavior is.)

[danslo]

I think it had to do with code generation and having to copy constructor
params (and their names) from a child class of FilterIterator which then no
longer matched their implementation. Something along those lines. I'll keep
you updated.
On Jan 6, 2014 6:44 PM, "Sean Cannella" [email protected] wrote:

I'll park it for now. Does Magento2 have to rely on this and can it
instead only depend on sequence? (I think there's going to be a lot of
these and given Zend docs != Zend code it's unclear what the "correct"
behavior is.)

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1492#issuecomment-31668896
.

[scannell]

Per above discussion we've decided not to pull this and we'll fix Magento instead. (The dependency on the parameter names when they don't match the docs is fragile without a language spec -- we're pretty much breaking something either way so no reason to move from the status quo.)