-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
capture_peer_cert for SSL context does not have any effect #2156
Labels
Comments
Looks like this is probably the reason |
Thanks for reporting this. Feel free to submit a PR if you (or someone else reading this) gets to this before we do. |
Looks to be fixed: https://3v4l.org/RUU3g |
facebook-github-bot
pushed a commit
that referenced
this issue
Mar 12, 2024
Summary: Pull Request resolved: facebook/folly#2156 Reviewed By: Gownta Differential Revision: D54646817 Pulled By: Orvid fbshipit-source-id: b693692932ef4e68cfdcdddbbbdf089841b53d88
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As far as I can tell, setting the
capture_peer_cert
option on the SSL stream context does not appear to have any effect. Thepeer_certificate
option is not populated after the request is made, so it's impossible to parse this out.To reproduce:
The text was updated successfully, but these errors were encountered: