Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for AMQP #1912

Closed
zegl opened this issue Feb 25, 2014 · 9 comments
Closed

Support for AMQP #1912

zegl opened this issue Feb 25, 2014 · 9 comments

Comments

@zegl
Copy link

zegl commented Feb 25, 2014

Hi!

Is there any plans of including a AMQP-library (with RabbitMQ support) in HHVM?

http://pecl.php.net/package/amqp

@scannell
Copy link
Contributor

Thanks for reporting this. We don't have any current plans on the team but you're more than welcome to port it to our extension model for everyone to use.

@saada
Copy link

saada commented Jul 9, 2014

http://docs.hhvm.com/manual/en/book.amqp.php
Is this resolved above?

@romainneutron
Copy link

@saada Have a look at http://docs.hhvm.com/manual/en/amqpconnection.construct.php, it's NOT SUPPORTED IN HHVM

@jippi
Copy link

jippi commented Apr 1, 2015

Is there any plans to implement AMQP ?

@fproject
Copy link

Please anyone port a AMQP extension to HHVM?

We urgently need it.

@akalend
Copy link

akalend commented Sep 8, 2015

I begining the port AMQP project https://github.com/akalend/hhvm-amqp
I need help in testing and writing documentation

@paulbiss
Copy link
Contributor

Looks like there's an external project for this now.

@tslettebo
Copy link

Unfortunately, the Github extension no longer works with the latest version of RabbitMQ Library. I've talked with the author, and he confirms this.

We're using AMQP in our company, and we'd like to start using HHVM/Hack, but this prevents us from doing that.

Therefore, I'd appreciate it if this issue could be reopened.

@fredemmott
Copy link
Contributor

Re-opening for now, though we're fairly likely to bulk-close extension request issues soon: we're extremely unlikely to implement any within the next year at least, given we need to develop Hack replacements for the PHP extensions that we already ship.

Your best option is probably to look at updating that external project yourself.

facebook-github-bot pushed a commit that referenced this issue Jan 14, 2023
Summary:
X-link: facebook/folly#1912
Closes: facebook/folly#1867

The `std::__vector_base` class in libc++ is removed in libc++ 15 (llvm/llvm-project@b82da8b). So the two current implementations of the hacks - the implementation for libc++ 14 and the implementation for earlier libc++ - both fail.

Even with libc++ 14, which retains `std::__vector_base`, Xcode 14 fails to compile the hacks:

```
In file included from folly/memory/test/UninitializedMemoryHacksODR.cpp:17:
folly/memory/UninitializedMemoryHacks.h:461:1: error: conversion from 'std::__vector_base<char, std::allocator<char>>::pointer std::__vector_base<char, std::allocator<char>>::*' to 'char *std::vector<char>::*' is not allowed in a converted constant expression
FOLLY_DECLARE_VECTOR_RESIZE_WITHOUT_INIT(char)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
folly/memory/UninitializedMemoryHacks.h:327:7: note: expanded from macro 'FOLLY_DECLARE_VECTOR_RESIZE_WITHOUT_INIT'
      &std::vector<TYPE>::__end_,                                    \
      ^~~~~~~~~~~~~~~~~~~~~~~~~~
...
```

Since libc++ is unlikely to change the internal layout of `std::vector` on a cadence which is too frequent for folly - any material change would be an ABI break -, we can use a layout struct rather than a template instance for the hacks and have it work for a range of versions of libc++ and Xcode.

Reviewed By: simpkins, swolchok

Differential Revision: D42459219

fbshipit-source-id: e23ef383869681b5c81e4301114020b9089c7461
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants