Move memory layout and common methods of AlignedHeapSegment to AlignedHeapSegmentBase #1510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D61675022 |
lavenzg
force-pushed
the
export-D61675022-to-static_h
branch
from
d72cbd2 to
dc062c7
Compare
lavenzg
added a commit
to lavenzg/hermes
that referenced
this pull request
Oct 21, 2024
…dHeapSegmentBase (facebook#1510) Summary: The large heap segment type should have the same storage layout as current AlignedHeapSegment, and share a few common methods. Abstract these to a base class, and make both AlignedHeapSegment and JumboHeapSegment inherit from the base type. Differential Revision: D61675022
|
This pull request was exported from Phabricator. Differential Revision: D61675022 |
lavenzg
added a commit
to lavenzg/hermes
that referenced
this pull request
Oct 21, 2024
…dHeapSegmentBase (facebook#1510) Summary: The large heap segment type should have the same storage layout as current AlignedHeapSegment, and share a few common methods. Abstract these to a base class, and make both AlignedHeapSegment and JumboHeapSegment inherit from the base type. Differential Revision: D61675022
lavenzg
added a commit
to lavenzg/hermes
that referenced
this pull request
Oct 21, 2024
…dHeapSegmentBase (facebook#1510) Summary: The large heap segment type should have the same storage layout as current AlignedHeapSegment, and share a few common methods. Abstract these to a base class, and make both AlignedHeapSegment and JumboHeapSegment inherit from the base type. Differential Revision: D61675022
lavenzg
added a commit
to lavenzg/hermes
that referenced
this pull request
Oct 21, 2024
…dHeapSegmentBase (facebook#1510) Summary: The large heap segment type should have the same storage layout as current AlignedHeapSegment, and share a few common methods. Abstract these to a base class, and make both AlignedHeapSegment and JumboHeapSegment inherit from the base type. Differential Revision: D61675022
lavenzg
added a commit
to lavenzg/hermes
that referenced
this pull request
Oct 21, 2024
…dHeapSegmentBase (facebook#1510) Summary: The large heap segment type should have the same storage layout as current AlignedHeapSegment, and share a few common methods. Abstract these to a base class, and make both AlignedHeapSegment and JumboHeapSegment inherit from the base type. Differential Revision: D61675022
lavenzg
added a commit
to lavenzg/hermes
that referenced
this pull request
Oct 22, 2024
…dHeapSegmentBase (facebook#1510) Summary: The large heap segment type should have the same storage layout as current AlignedHeapSegment, and share a few common methods. Abstract these to a base class, and make both AlignedHeapSegment and JumboHeapSegment inherit from the base type. Differential Revision: D61675022
lavenzg
added a commit
to lavenzg/hermes
that referenced
this pull request
Nov 8, 2024
…dHeapSegmentBase (facebook#1510) Summary: The large heap segment type should have the same storage layout as current AlignedHeapSegment, and share a few common methods. Abstract these to a base class, and make both AlignedHeapSegment and JumboHeapSegment inherit from the base type. Differential Revision: D61675022
lavenzg
added a commit
to lavenzg/hermes
that referenced
this pull request
Nov 8, 2024
…dHeapSegmentBase (facebook#1510) Summary: The large heap segment type should have the same storage layout as current AlignedHeapSegment, and share a few common methods. Abstract these to a base class, and make both AlignedHeapSegment and JumboHeapSegment inherit from the base type. Differential Revision: D61675022
lavenzg
added a commit
to lavenzg/hermes
that referenced
this pull request
Nov 8, 2024
…dHeapSegmentBase (facebook#1510) Summary: The large heap segment type should have the same storage layout as current AlignedHeapSegment, and share a few common methods. Abstract these to a base class, and make both AlignedHeapSegment and JumboHeapSegment inherit from the base type. Differential Revision: D61675022
lavenzg
added a commit
to lavenzg/hermes
that referenced
this pull request
Dec 3, 2024
… class (facebook#1510) Summary: The large heap segment type should have the same storage layout as current AlignedHeapSegment, and share a few common methods. Abstract these to a base class, and make both FixedSizeHeapSegment and JumboHeapSegment inherit from the base type. Differential Revision: D61675022
lavenzg
force-pushed
the
export-D61675022-to-static_h
branch
from
dc062c7 to
6440690
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61675022 |
lavenzg
added a commit
to lavenzg/hermes
that referenced
this pull request
Dec 3, 2024
… class (facebook#1510) Summary: The large heap segment type should have the same storage layout as current AlignedHeapSegment, and share a few common methods. Abstract these to a base class, and make both FixedSizeHeapSegment and JumboHeapSegment inherit from the base type. Differential Revision: D61675022
lavenzg
force-pushed
the
export-D61675022-to-static_h
branch
from
6440690 to
2617ce6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61675022 |
Summary: With this change, we can remove the dependency on GCCell.h in the header. Reviewed By: neildhar Differential Revision: D66727534
… class (facebook#1510) Summary: The large heap segment type should have the same storage layout as current AlignedHeapSegment, and share a few common methods. Abstract these to a base class, and make both FixedSizeHeapSegment and JumboHeapSegment inherit from the base type. Reviewed By: neildhar Differential Revision: D61675022
lavenzg
force-pushed
the
export-D61675022-to-static_h
branch
from
2617ce6 to
d27151b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61675022 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The large heap segment type should have the same storage layout as
current AlignedHeapSegment, and share a few common methods. Abstract
these to a base class, and make both AlignedHeapSegment and
JumboHeapSegment inherit from the base type.
Differential Revision: D61675022