Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSError: look for stack data in the prototype chain #1497

Closed
wants to merge 1 commit into from
Closed

JSError: look for stack data in the prototype chain #1497

wants to merge 1 commit into from

Conversation

tmikov
Copy link
Contributor

@tmikov tmikov commented Aug 27, 2024

Summary:
Look for stack data in the entire prototype chain in order to accommodate
usage like the one in the test.

See #1496

Differential Revision: D61870728

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 27, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61870728

@tmikov tmikov mentioned this pull request Aug 27, 2024
Closed
1 task
@thomasttvo
Copy link

Thank you so much for the fix 🙏 🙏 🙏 🙏 🙏
I have one small question. Would there be a way we could avoid raising the type error at the end of getErrorFromStackTarget?

@facebook-github-bot
JSError: look for stack data in the prototype chain (facebook#1497)
d9f2472 
Summary:
Pull Request resolved: facebook#1497

Look for stack data in the entire prototype chain in order to accommodate
usage like the one in the test.

See facebook#1496

Reviewed By: avp

Differential Revision: D61870728
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61870728

@tmikov tmikov force-pushed the export-D61870728-to-static_h branch from 3efcc29 to d9f2472 Compare August 28, 2024 15:22
facebook-github-bot pushed a commit that referenced this pull request Aug 28, 2024
@facebook-github-bot
JSError: look for stack data in the prototype chain (#1497)
8b7a9f8 
Summary:
Pull Request resolved: #1497

Look for stack data in the entire prototype chain in order to accommodate
usage like the one in the test.

See #1496

Reviewed By: avp

Differential Revision: D61870728

fbshipit-source-id: 9a1008cddcd8a87f96363922691460aa7f85224a
@tmikov
Copy link
Contributor Author

tmikov commented Aug 29, 2024

I don't think we can avoid throwing an error from the getter when there is nothing to get from.

@tmikov tmikov closed this Aug 29, 2024
@tmikov tmikov deleted the export-D61870728-to-static_h branch August 29, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tmikov @facebook-github-bot @thomasttvo