Update sampling profiler thread #1421
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D57397716 |
|
This pull request was exported from Phabricator. Differential Revision: D57397716 |
2 similar comments
|
This pull request was exported from Phabricator. Differential Revision: D57397716 |
|
This pull request was exported from Phabricator. Differential Revision: D57397716 |
Summary: Allow repeated calls to enable the sampling profiler, updating the thread targeted by the profiler each time. Previously, the sampling profiler would target only a single thread. If the runtime was used from another thread, multiple threads would be trying to use the runtime in parallel, causing incorrect behavior. Reviewed By: avp Differential Revision: D57397716
|
This pull request was exported from Phabricator. Differential Revision: D57397716 |
|
This pull request has been merged in 8991646. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 18, 2024
Summary: Original Author: [email protected] Original Git: 8991646 Original Reviewed By: avp Original Revision: D57397716 Pull Request resolved: #1421 Allow repeated calls to enable the sampling profiler, updating the thread targeted by the profiler each time. Previously, the sampling profiler would target only a single thread. If the runtime was used from another thread, multiple threads would be trying to use the runtime in parallel, causing incorrect behavior. Reviewed By: neildhar Differential Revision: D58706799 fbshipit-source-id: 3171b2774dba055f9a8f3c3ee44535f9d56e03b4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Allow repeated calls to enable the sampling profiler,
updating the thread targeted by the profiler each time.
Previously, the sampling profiler would target only a
single thread. If the runtime was used from another
thread, multiple threads would be trying to use the
runtime in parallel, causing incorrect behavior.
Reviewed By: avp
Differential Revision: D57397716