Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix link in README #12

Closed
wants to merge 1 commit into from
Closed

Fix link in README #12

wants to merge 1 commit into from

Conversation

tfolbrecht
Copy link
Contributor

Fix CoC link in readme, (different one than #11)

@tfolbrecht
Fix link in README
125da38 
Fix CoC link in readme, (different one than #11)
@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jul 11, 2019
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

facebook-github-bot
facebook-github-bot reviewed Jul 11, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@hramos merged this pull request in 5276efe.

facebook-github-bot pushed a commit that referenced this pull request Oct 21, 2019
@dreiss @facebook-github-bot
Fix argument name in make_jstring (#12)
3da47c9 
Summary:
These take real UTF-8, not modified.
Pull Request resolved: facebookincubator/fbjni#12

Test Plan: CI

Reviewed By: BurntBrunch

Differential Revision: D18030971

Pulled By: dreiss

fbshipit-source-id: d8dff2d9f053da21c84fd7d6bb3dffa140f24f49
@whatleo whatleo mentioned this pull request Apr 1, 2021
Closed
@vietmobilefolk vietmobilefolk mentioned this pull request Sep 22, 2022
Closed
@DevFuan DevFuan mentioned this pull request Jan 12, 2023
Closed
@iwater iwater mentioned this pull request May 25, 2023
Closed
1 task
@JimWongM JimWongM mentioned this pull request Jun 17, 2023
Open
@atoui-zahreddine atoui-zahreddine mentioned this pull request Feb 9, 2024
Closed
2 tasks
@jtdaugh jtdaugh mentioned this pull request Jul 9, 2024
Closed
2 tasks
@hopestar90 hopestar90 mentioned this pull request Oct 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tfolbrecht @facebook-github-bot