Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Intl API documentation to include iOS support #1042

Closed
wants to merge 1 commit into from

Conversation

jobpaardekooper
Copy link
Contributor

@jobpaardekooper jobpaardekooper commented Jun 29, 2023

Summary

As discussed in issue #1035, the documentation of the Intl APIs does not include the current state of the iOS support. This PR adds this information and formats the page to reflect that this page now talks about Android and iOS support and not just Android. Also the "Not yet supported" sections has been removed. The page now only mentions what is supported and the limitations of the functionalities that are currently supported. This makes more sense with regard to the still changing specification. Mentioning what is supported automatically means the remaining information from the spec that is not included under "supported" is not currently supported.

Copy link
Contributor

@neildhar neildhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this! Some minor comments.

doc/IntlAPIs.md Outdated Show resolved Hide resolved
doc/IntlAPIs.md Outdated Show resolved Hide resolved
doc/IntlAPIs.md Outdated Show resolved Hide resolved
doc/IntlAPIs.md Show resolved Hide resolved
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jun 29, 2023
doc/IntlAPIs.md Outdated Show resolved Hide resolved
doc/IntlAPIs.md Show resolved Hide resolved
doc/IntlAPIs.md Outdated Show resolved Hide resolved
doc/IntlAPIs.md Outdated Show resolved Hide resolved
@facebook-github-bot
Copy link
Contributor

@neildhar has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@neildhar merged this pull request in 28e1a33.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants