Skip to content

Commit

Permalink
Remove the package exclusions (#51)
Browse files Browse the repository at this point in the history
Summary:
It's all a little confusing but downstream consumers of Flipper
that don't use CMake themselves otherwise don't have access to these
libraries and will have them missing from their builds.

I'll create an 0.2.0 release for this so 0.1.0 consumers don't
end up with multiple binaries.

Pull Request resolved: facebookincubator/fbjni#51

Test Plan:
Tested locally with Flipper and a stand-alone example and it seems to
work.

Reviewed By: mweststrate

Differential Revision: D26815786

Pulled By: passy

fbshipit-source-id: c70b56952acbe6e3be4ef74da2e4115651ce8e9c
  • Loading branch information
passy authored and facebook-github-bot committed Mar 4, 2021
1 parent be73acd commit 18ee43c
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions first-party/fbjni/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -81,14 +81,6 @@ android {
headers 'cxx/'
}
}

// There's a bug in prefab that will bundle all these twice, causing the
// consumer to get duplicate errors.
// Followed the advice from https://github.com/chancezeus/libjpeg-turbo-android-prefab/blob/18eaa325e9954b832c9f3c95e141361d86746528/libjpeg-turbo/build.gradle
packagingOptions {
exclude("**/libfbjni.so")
exclude("**/libc++_shared.so")
}
}
}

Expand Down

0 comments on commit 18ee43c

Please sign in to comment.